Replace kcd-scripts prettier#416
Conversation
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Changing the name to be agnostic of the tool we use.
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
No blockers from me, this is nice and clean!
Only a couple of suggestions that I think might be better as followups. No preference on my end.
Linking & recapping #402 (comment): its job (disabling ESLint rules that conflict with Prettier) is no longer necessary. 🔪 |
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Oh, so does that mean we can get rid of the dependency all together? I feel in the last 30 minutes I've learned a lot about Husky, Prettier, Lint Staged and ESLint for npm packages 😆. The Prettier docs suggested conflicts with ESLint can happen so you should use that package and be careful in which order you call them. |
Yup! Unless something regressed in 2025,
Oh, where did you see this? They might need updating to note that this is typically only true for custom and/or legacy configs. |
|
Oof thanks! Filed: prettier/prettier#18859 |
3 participants
Closes #415
Depends on #402
This copies the
kcd-scriptsprettier config into the repo.This did result in some changes to the source files but the rules don't seem to conflict with eslint so I think it is fine if we are happy with the style.
I put the prettier config in an
rcfile. I'm not sure if there is much advantage to having anmjsfile instead. We could switch if we want to do something more complex.I presume
eslint-config-prettieris doing it's job. That is configured ineslint.config.mjs, but I don't really understand what is going on in that file.